Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test: temporarily exempt SynthPorep constants from test #11259

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Sep 8, 2023

Related Issues

TestSDRLayersDefined has been failing on master, it's new in #11011. This is because it tests over all SealProofInfos as defined in go-state-types, which includes synth porep stuff.

Proposed Changes

  • Explicitly skip this check for the synth porep range for now
  • We should remove this when feat/nv21 is merged into master (will open issue for it)
  • The real solution is that we're gonna need to start having integration branches in go-state-types for stuff like this

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner September 8, 2023 15:51
@arajasek
Copy link
Contributor Author

arajasek commented Sep 8, 2023

Issue to undo this: #11260

@arajasek arajasek merged commit d70674c into master Sep 8, 2023
@arajasek arajasek deleted the asr/quick-fix branch September 8, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants